-
-
Notifications
You must be signed in to change notification settings - Fork 129
e2e: add iOS 26 + XCode 26 tests #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kirillzyusko
wants to merge
14
commits into
main
Choose a base branch
from
ci/add-ios26-xcode26-e2e-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+48
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📊 Package size report
|
ada6984 to
d5a44f0
Compare
11439eb to
a7c3889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Added e2e tests assembled with XCode 26 and tested on iOS 26.
💡 Motivation and Context
The problem with iOS 26 keyboard is that it has two states:
In this PR I'm covering new keyboard functionality. We want to make keyboard controller stable across all OS versions and this step is crucial in terms of guarantee that lib works in all conditions (i. e. backward compatible mode and new mode).
This PR reveals some inconsistencies:
KeyboardBackgroundViewdoesn't match real keyboard background color anymore;I also intentionally test new keyboard on iOS 26.1, because iOS 26.0 wasn't really stable (it had animation jumps etc.)
I hope new tests will help me to catch bugs earlier rather than later, tough I have feeling like I'm overusing GitHub CI (now I run 6 iOS e2e jobs 🤯). I may revisit the approach later and maybe run only few jobs for PRs and all test cases when merge into main 🤷♂️
📢 Changelog
E2E
KeyboardExtenderthreshold (after detach I can see rounded corners of keyboard)CI
🤔 How Has This Been Tested?
Tested via this PR.
📸 Screenshots (if appropriate):
📝 Checklist